Add a separate setup-godot-cpp github action. #1656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
force-pushed
the
gh-action-setup-godot-cpp
branch
from
7f28e85 to
fb06c07
Compare
Member
Author
|
Looks like caches are still working, plus the tests in godotengine/godot-cpp-template#70 have succeeded (especially, the Android ones which I was unsure of). I'm taking this as a good sign that this PR retains cross compatibility! |
Ivorforce
commented
Nov 27, 2024
dsnopek
approved these changes
Dec 6, 2024
Collaborator
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Overall, this seems good to me! It's really just moving a small amount of stuff from the workflow into an action
Ivorforce
force-pushed
the
gh-action-setup-godot-cpp
branch
2 times, most recently
from
e17cee9 to
090abe2
Compare
dsnopek
added
enhancement
dsnopek
reviewed
Dec 9, 2024
Ivorforce
force-pushed
the
gh-action-setup-godot-cpp
branch
from
090abe2 to
9943675
Compare
Collaborator
|
Cherry-picked for 4.2 in PR #1694 |
Collaborator
|
Cherry-picked for 4.3 in PR #1695 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the godot-cpp meeting. This action is specifically intended to be used by dependants of godot-cpp, to set up godot-cpp in their own github workflows. A follow-up PR will use this github action in godot-cpp-template (edit: godotengine/godot-cpp-template#70).
There are quite a few differences to godot-cpp-template's setup steps. I don't know if they started the same but diverged later, or if godot-cpp-template has always made different decisions from godot-cpp itself. Here is godot-cpp-template's version for reference.
I based my implementation mostly on godot-cpp. Here are the key differences I see:
actions/setup-java@v4andandroid-actions/setup-android@v3are used on godot-cpp-template, whilenttld/setup-ndk@v1is used on godot-cpp.godot-cpp-template, while they are explicitly disabled ongodot-cpp. This was recently decided in [Web] Don't cache emsdk #1639 and should not be reverted.build-essential pkg-configon linux. godot-cpp only installs these dependencies for the cmake build. I conclude they may not be needed for scons builds.I think that's all of the differences, though the github runner shall smite my PR if it's not compatible anymore.